win,build: forward release_urlbase to configure #8430
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The RELEASE_URLBASE environment variable is used in releases as a prefix for links in the process.release object. The Makefile picks it and forwards it to configure, but vcbuild.bat did not. Hence, in Windows, Node releases have a correct process.release because it uses the default URL, but nightlies, RCs and so on do not, breaking node-gyp. This enables native modules to be built with such versions of Node.
joaocgreis
added
windows
|
LGTM |
|
Nothing in CI tests, but just to be extra safe: https://ci.nodejs.org/job/node-test-commit/4973/ The arm failure is certainly unrelated. |
orangemocha
pushed a commit
that referenced
this pull request
Sep 9, 2016
The RELEASE_URLBASE environment variable is used in releases as a prefix for links in the process.release object. The Makefile picks it and forwards it to configure, but vcbuild.bat did not. Hence, in Windows, Node releases have a correct process.release because it uses the default URL, but nightlies, RCs and so on do not, breaking node-gyp. This enables native modules to be built with such versions of Node. PR-URL: #8430 Reviewed-By: jbergstroem - Johan Bergström <[email protected]>
|
Landed in 137b7cb (@joaocgreis is off today, I am landing this on his behalf so that this can make the v7.x cut on Monday). |
Fishrock123
pushed a commit
that referenced
this pull request
Sep 14, 2016
The RELEASE_URLBASE environment variable is used in releases as a prefix for links in the process.release object. The Makefile picks it and forwards it to configure, but vcbuild.bat did not. Hence, in Windows, Node releases have a correct process.release because it uses the default URL, but nightlies, RCs and so on do not, breaking node-gyp. This enables native modules to be built with such versions of Node. PR-URL: #8430 Reviewed-By: jbergstroem - Johan Bergström <[email protected]>
joaocgreis
added a commit
to JaneaSystems/node
that referenced
this pull request
Sep 14, 2016
The RELEASE_URLBASE environment variable is used in releases as a prefix for links in the process.release object. The Makefile picks it and forwards it to configure, but vcbuild.bat did not. Hence, in Windows, Node releases have a correct process.release because it uses the default URL, but nightlies, RCs and so on do not, breaking node-gyp. This enables native modules to be built with such versions of Node. PR-URL: nodejs#8430 Reviewed-By: jbergstroem - Johan Bergström <[email protected]>
|
@joaocgreis should this be backported? |
|
@thealphanerd yes, thanks! |
MylesBorins
pushed a commit
that referenced
this pull request
Oct 11, 2016
The RELEASE_URLBASE environment variable is used in releases as a prefix for links in the process.release object. The Makefile picks it and forwards it to configure, but vcbuild.bat did not. Hence, in Windows, Node releases have a correct process.release because it uses the default URL, but nightlies, RCs and so on do not, breaking node-gyp. This enables native modules to be built with such versions of Node. PR-URL: #8430 Reviewed-By: jbergstroem - Johan Bergström <[email protected]>
rvagg
pushed a commit
that referenced
this pull request
Oct 18, 2016
The RELEASE_URLBASE environment variable is used in releases as a prefix for links in the process.release object. The Makefile picks it and forwards it to configure, but vcbuild.bat did not. Hence, in Windows, Node releases have a correct process.release because it uses the default URL, but nightlies, RCs and so on do not, breaking node-gyp. This enables native modules to be built with such versions of Node. PR-URL: #8430 Reviewed-By: jbergstroem - Johan Bergström <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 26, 2016
The RELEASE_URLBASE environment variable is used in releases as a prefix for links in the process.release object. The Makefile picks it and forwards it to configure, but vcbuild.bat did not. Hence, in Windows, Node releases have a correct process.release because it uses the default URL, but nightlies, RCs and so on do not, breaking node-gyp. This enables native modules to be built with such versions of Node. PR-URL: #8430 Reviewed-By: jbergstroem - Johan Bergström <[email protected]>
Closed
joaocgreis
added a commit
to joaocgreis/node-chakracore
that referenced
this pull request
Nov 16, 2016
The RELEASE_URLBASE environment variable is used in releases as a prefix for links in the process.release object. The Makefile picks it and forwards it to configure, but vcbuild.bat did not. Hence, in Windows, Node releases have a correct process.release because it uses the default URL, but nightlies, RCs and so on do not, breaking node-gyp. This enables native modules to be built with such versions of Node. PR-URL: nodejs/node#8430 Reviewed-By: jbergstroem - Johan Bergström <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
Windows, Build.
Description of change
The
RELEASE_URLBASEenvironment variable is used in releases as a prefix for links in theprocess.releaseobject (#2154). TheMakefilepicks it and forwards it toconfigure, butvcbuild.batdid not. Hence, in Windows, Node releases have a correctprocess.releasebecause it uses the default URL, but nightlies, RCs and so on do not, breaking node-gyp. This enables native modules to be built with such versions of Node.cc @nodejs/platform-windows